| commit | a28297906171087060b4c23d72d093b1d5e791b8 | [log] [tgz] |
|---|---|---|
| author | Mohamed Heikal <mheikal@chromium.org> | Thu Jun 27 21:47:37 2024 |
| committer | Mohamed Heikal <mheikal@chromium.org> | Thu Jun 27 21:47:37 2024 |
| tree | 97d1b1a97453452e210fc0ff81be529f5ac3cfb8 | |
| parent | 07a150e971a5a01cad9cbb05d386c1f4a4eefc6e [diff] |
Put size summary in the Chromium Binary Size chip The binary size is currently hidden behind the checks tab making it basically invisible in cases it succeeds. This cl adds the size delta into the chip itself so as to surface the most important number more easily. Also fixes lint/formatting. Bug: None Change-Id: Ic35296b2104280bf1207b9e85b02421811014c67
The plugin queries the android-binary-size trybot for the current patchset on Gerrit, and gets the binary_size_plugin property. This property contains the metadata about the binary size metrics affected by the patchset in question. It then shows a table with the metric deltas + links to SuperSize output under the Checks tab.
This plugin is configured via the chromium-binary-size.config file present in the repo‘s refs/meta/config ref, as well as the same file in all repositories in the repo’s inheritance chain (up to and including All-Projects).
An example chromium-binary-size.config is below (this enables the plugin on the chromium/src repo using the android-binary-size trybot:
[host] gerrit = "chromium-review.googlesource.com" [repo "chromium/src"] builder = "android-binary-size" bucket = "try" project = "chromium"
All changes to chromium-binary-size.config files are instantly reflected. There is no caching period or need to restart the server.
This plugin must be placed inside the Gerrit plugins directory:
git clone --recurse-submodules https://gerrit.googlesource.com/gerrit cd gerrit/plugins git clone https://chromium.googlesource.com/infra/gerrit-plugins/chromium-binary-size
Run the commands below in web/.
For running Java unit tests execute:
make test_java
For running TypeScript unit tests execute:
make test
For checking or fixing eslint formatter problems run:
make lint_test make lint_fix
For testing the plugin with Gerrit FE Dev Helper the command below builds the JavaScript bundle and copies it to the plugins/chromium-binary-size folder:
make build
and let the Dev Helper redirect from .+/plugins/chromium-binary-size/static/chromium-binary-size.js to http://localhost:8081/plugins_/plugins/chromium-binary-size.js.